fix commit retrieval loop. #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dlamoris
reviewed
May 14, 2024
| @@ -156,7 +157,7 @@ public List<Commit> findByRefAndTimestampAndLimit(Branch ref, Instant timestamp, | |||
| currentRef = ref.getParentRefId(); | |||
| currentCid = ref.getParentCommit(); | |||
|
|
|||
| if (currentRef == null) { | |||
| if (currentRef == null || currentRef.equals(Constants.MASTER_BRANCH)) { | |||
There was a problem hiding this comment.
This breaks the tests since it stops at a branch whose parent is master.
master branch is created with parent ref being null, it may be you had some bad db data from a dev branch for some reason had master with master parent
|
dlamoris
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loop was happening in the background where commits were just piling up or never returning unless a limit was set.