-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistence refactor #235
Persistence refactor #235
Conversation
…ers. Introduces a unified persistence layer interface with a federated implementation. Added msosa, view, and oauth modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
rdb/src/main/java/org/openmbee/mms/rdb/config/DatabaseDefinitionService.java
Dismissed
Show dismissed
Hide dismissed
crud/src/main/java/org/openmbee/mms/crud/controllers/orgs/OrgsController.java
Dismissed
Show dismissed
Hide dismissed
return false; | ||
} | ||
} catch (ParseException e) { | ||
logger.info("date parse exception: {} {}", jsonModified, existingModified); |
Check failure
Code scanning / CodeQL
Log Injection High
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
This log entry depends on a user-provided value.
...nce/src/main/java/org/openmbee/mms/federatedpersistence/dao/FederatedProjectPersistence.java
Dismissed
Show dismissed
Hide dismissed
...nce/src/main/java/org/openmbee/mms/federatedpersistence/dao/FederatedWebhookPersistence.java
Dismissed
Show dismissed
Hide dismissed
oauth/src/main/java/org/openmbee/mms/oauth/config/OAuthSecurityConfig.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/org/openmbee/mms/core/services/DefaultPermissionService.java
Dismissed
Show dismissed
Hide dismissed
crud/src/main/java/org/openmbee/mms/crud/services/DefaultBranchService.java
Dismissed
Show dismissed
Hide dismissed
...ence/src/main/java/org/openmbee/mms/federatedpersistence/dao/FederatedCommitPersistence.java
Dismissed
Show dismissed
Hide dismissed
…th persistence implementation
crud/src/main/java/org/openmbee/mms/crud/controllers/elements/ElementsController.java
Dismissed
Show dismissed
Hide dismissed
…preventing them from getting transaction proxies created
crud/src/main/java/org/openmbee/mms/crud/domain/DefaultNodeUpdateFilter.java
Fixed
Show fixed
Hide fixed
@HuiJun How do you want to handle all of the "This log entry depends on a user defined value." errors? |
@BA-MBSE I think the play here is to ignore them for now, with a note to fix before the next release. |
SonarCloud Quality Gate failed. 1 Bug No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
rdb/src/main/java/org/openmbee/mms/rdb/config/DatabaseDefinitionService.java
Dismissed
Show dismissed
Hide dismissed
branch was pushed to main repo, see #259 |
This PR decouples the federated (ES + PG) persistence layer from the Controller and Service layers, and replaces it with a unified persistence interface layer. Provided is a rehost of the ES + PG persistence layer as an implementation of the unified persistence layer (federatedpersistence).
Decoupled view controller from cameo module, added view module.
Added msosa module as schema for 2021x + MagicDraw Schema
Added oauth module