Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7 workbook #61

Merged
merged 15 commits into from
Jan 7, 2025
Merged

v7 workbook #61

merged 15 commits into from
Jan 7, 2025

Conversation

prakaa
Copy link
Member

@prakaa prakaa commented Dec 12, 2024

Minor fixes:

  • When configs are loaded for a workbook, workbook parser will now check whether a sheet in the workbook matches the config sheet name in a case insensitive manner. This way, case changes to workbook names don't need to be addressed between versions
  • Column sanitisation (i.e. removing footnotes) had incorrect regex. However, to ensure that the trailing number in REZ names isn't deleted (e.g. N1, V0), I had to not match any instance where the number is preceded by a capital letter. This means that some footnotes have been re-introduced (e.g. CCGT2). Not sure how to better deal with this since the regex is using a negative lookbehind that checks for a few things (including a capital letter), and negative lookbehind must have fixed lengths

Config changes for v7

  • Some tables (presumably some provided by consultants) will be provided in Stage 2 of the consultation, so these yamls have been commented out
  • I have fixed configs that raise errors but not checked for new tables, unless the new tables were located in existing sheets where I was fixing errors

@prakaa prakaa requested a review from nick-gorman December 12, 2024 03:41
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

Copy link
Member

@nick-gorman nick-gorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've just added functionality to remove the footnotes that got reintroduced and a test for the workbook sheet names missing error.

@nick-gorman nick-gorman merged commit b2b3487 into main Jan 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants