-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement translations for data source seeder/ data catalogue route #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
database testing passed @lemilonkh is there anything required on your end if the datatypes change from text to jsonb, if not we can approve.
@lemilonkh I changed the format of the file, csv to yaml. |
@mfonsecaOEF is the data catalogue route updated to handle these new data types? Did you test it? |
@mfonsecaOEF let's make sure the |
added new api route for languages @lemilonkh if you can re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, that should keep it compatible with the current CityCatalyst version! ✨
This PR contains:
en
andes
for different columns in the datasource table