Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement translations for data source seeder/ data catalogue route #496

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

mfonsecaOEF
Copy link
Contributor

This PR contains:

  • yaml file with the translations in en and es for different columns in the datasource table
  • migration file with change of text type to jsonb type for those columns

@mfonsecaOEF mfonsecaOEF requested a review from amanda-eames May 23, 2024 11:26
@mfonsecaOEF mfonsecaOEF self-assigned this May 23, 2024
Copy link
Contributor

@amanda-eames amanda-eames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

database testing passed @lemilonkh is there anything required on your end if the datatypes change from text to jsonb, if not we can approve.

@mfonsecaOEF mfonsecaOEF reopened this May 24, 2024
@mfonsecaOEF
Copy link
Contributor Author

@lemilonkh I changed the format of the file, csv to yaml.
Please LMK if I need to add something else to this PR

@lemilonkh lemilonkh added enhancement New feature or request python Pull requests that update Python code database Data model or migration changes labels May 27, 2024
@lemilonkh lemilonkh changed the title On 620 allowing other languages Implement translations for data source seeder/ data catalogue route May 27, 2024
@lemilonkh
Copy link
Contributor

@mfonsecaOEF is the data catalogue route updated to handle these new data types? Did you test it?

@lemilonkh
Copy link
Contributor

@mfonsecaOEF let's make sure the v0 endpoints return only the English strings, and add a v1 of the endpoint that returns { "en": "Name", "es": "Nombre", ... } for every translatable string (that will be shown to the end user, so no formula identifiers etc.).

@amanda-eames
Copy link
Contributor

added new api route for languages @lemilonkh if you can re-review

Copy link
Contributor

@lemilonkh lemilonkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that should keep it compatible with the current CityCatalyst version! ✨

@amanda-eames amanda-eames merged commit a6cc99d into develop Aug 5, 2024
1 check failed
@amanda-eames amanda-eames deleted the ON-620_allowing_other_languages branch August 5, 2024 13:41
@amanda-eames amanda-eames restored the ON-620_allowing_other_languages branch August 6, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Data model or migration changes enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants