Feature/send notification #384
Conversation
|
It doesn't look like the requested changes were made. @cephaschapa ? |
| }; | ||
| const host = process.env.HOST ?? "http://localhost:3000"; | ||
|
|
||
| const emailTemplate = ` |
There was a problem hiding this comment.
Create mock for the send email functionality
There was a problem hiding this comment.
Render template using React-Email again and move this to NotificationService.
|
|
||
| `; | ||
|
|
||
| if (process.env.NODE_ENV !== "test") { |
There was a problem hiding this comment.
Mock this so you don't need to check here
| @@ -58,6 +62,19 @@ export const GET = apiHandler(async (_req: Request, context) => { | |||
|
|
|||
| export const POST = apiHandler(async (req: NextRequest, context) => { | |||
| const userId = context.session?.user.id; | |||
| const service = new NotificationService(); | |||
There was a problem hiding this comment.
Use static methods and don't create an instance of NotificationService here.
| private transporter: Transporter; | ||
| constructor() { | ||
| this.transporter = nodemailer.createTransport({ ...smtpOptions }); | ||
| } |
There was a problem hiding this comment.
No state in service. Create this in sendEmail or create static helper method in NotificationService.
| this.transporter = nodemailer.createTransport({ ...smtpOptions }); | ||
| } | ||
|
|
||
| async sendEmail({ |
There was a problem hiding this comment.
Should be static so it can be called like this: await NotificationService.sendEmail(...);
Also this should handle template rendering with react-email.
Changes