Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information about sources to data catalog #370

Closed
wants to merge 7 commits into from

Conversation

mfonsecaOEF
Copy link
Contributor

this PR is about updates in the data catalog:

  • new columns
  • updated datasets and datasources
  • new migration file to update the current table
  • sql file

@mfonsecaOEF mfonsecaOEF self-assigned this Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

LCOV of commit ebfe113 during Push Web app to GHCR and deploy to EKS #837

Summary coverage rate:
  lines......: 61.7% (5663 of 9179 lines)
  functions..: 86.9% (245 of 282 functions)
  branches...: 88.8% (358 of 403 branches)

Files changed coverage rate: n/a

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.23%. Comparing base (b639346) to head (ebfe113).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #370   +/-   ##
========================================
  Coverage    61.23%   61.23%           
========================================
  Files           61       61           
  Lines         9179     9179           
  Branches        89       89           
========================================
  Hits          5621     5621           
  Misses        3553     3553           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfonsecaOEF mfonsecaOEF requested a review from lemilonkh March 11, 2024 20:50
@lemilonkh lemilonkh changed the title update:new_columns and datasource_info Add more information about sources to data catalog Mar 29, 2024
@lemilonkh
Copy link
Contributor

Please make these changes backwards compatible and fix the merge conflicts, then this PR can be merged.

@evanp
Copy link
Contributor

evanp commented Mar 29, 2024

This branch got merged with the Mendoza data. I managed to get the importer script and the Global API endpoints to use the new schema, but we might have other downstream issues. We can check today.

@lemilonkh
Copy link
Contributor

Merged in another PR, closing...

@lemilonkh lemilonkh closed this Mar 29, 2024
@mfonsecaOEF mfonsecaOEF deleted the datacatalog_update_v2 branch May 24, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants