Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Node Test Runner to Jest for compatibility #356

Merged
merged 30 commits into from
Sep 6, 2024
Merged

Switch from Node Test Runner to Jest for compatibility #356

merged 30 commits into from
Sep 6, 2024

Conversation

lemilonkh
Copy link
Contributor

  • Install jest
  • Setup and configure jest
  • Modify model tests to work with Jest
  • Remove unused config segments from jest.config.ts
  • Fix ESM module issues with jest by adjusting npm run test script
  • Fix ESM module issue in helpers.ts with import.meta.url
  • Convert city test to Jest

@lemilonkh lemilonkh requested a review from cephaschapa May 27, 2024 15:49
@lemilonkh lemilonkh self-assigned this May 27, 2024
@lemilonkh lemilonkh added enhancement New feature or request testing tooling labels May 27, 2024
@Open-Earth-Foundation Open-Earth-Foundation deleted a comment from evanp Jul 22, 2024
@lemilonkh
Install jest, ts-jest and other dev dependencies
626bb0e
@lemilonkh
Setup and configure jest
c5f80d8
@lemilonkh
Modify model tests to work with Jest
d70ff4b
@lemilonkh
Remove unused config segments from jest.config.ts
225867b
@lemilonkh
Fix ESM module issues with jest by adjusting npm run test script
6bbc680
@lemilonkh
Fix ESM module issue in helpers.ts with import.meta.url
0e02bd6
@lemilonkh
Convert city test to Jest
b01315a
@lemilonkh
Fix __dirname definition to not depend on __filename
8923cc2 
Not available in Jest
@lemilonkh
Install @jest/globals as a dev dependency
bea8066
@lemilonkh
Extract type ApiResponse
7bde948
@lemilonkh
Create test helper expectStatusCode
46997c1
@lemilonkh
Use expectStatusCode helper in userfile test
267b9c9
@lemilonkh
Switch other npm test commands to jest
8f8ff2a
@lemilonkh
Set testEnvironment to node in jest config
199f608
@lemilonkh
Reformat city test imports
7a213cc
@lemilonkh
Revert "Fix __dirname definition to not depend on __filename"
253a45c 
This reverts commit 2bdf7c3.
@lemilonkh
Set NODE_ENV in npm test script
af4937b
@lemilonkh
Rework inventory tests to use jest
f3a02f4
@lemilonkh
Convert inventory value tests to Jest
390cf0d
@lemilonkh
Remove custom __dirname logic in helpers.ts
ff35076
@lemilonkh
Fix misplaced await
1305088
@lemilonkh
Handle internal server errors better in API error handler
0780ab9
@lemilonkh
Remove unused import in inventory test
d5be418
@lemilonkh
Fix request text not being available in error case in inventory value…
aa9d1cc 
… test
@thehighestprimenumber
Copy link
Contributor

I have moved as many tests as I could to jest. Files ending in .jest.ts and are picked up by jest. Files ending in .test.ts are picked up by the node test runner.

@thehighestprimenumber thehighestprimenumber force-pushed the feature/jest branch 3 times, most recently from 0c12602 to 029edb0 Compare September 6, 2024 14:28
@thehighestprimenumber thehighestprimenumber marked this pull request as ready for review September 6, 2024 14:42
lemilonkh
lemilonkh commented Sep 6, 2024
View reviewed changes
Copy link
Contributor Author

@lemilonkh lemilonkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ✨

@thehighestprimenumber thehighestprimenumber merged commit a64e812 into develop Sep 6, 2024
3 checks passed
@thehighestprimenumber thehighestprimenumber deleted the feature/jest branch September 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehighestprimenumber thehighestprimenumber thehighestprimenumber approved these changes

@cephaschapa cephaschapa Awaiting requested review from cephaschapa

Assignees

@lemilonkh lemilonkh

Labels
enhancement New feature or request testing tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemilonkh @thehighestprimenumber