Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/disconnect third party data #355

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

cephaschapa
Copy link
Contributor

Changes

  • Adds route to delete inventoryValue
  • Adds api mutation in api service
  • Adds disconnect functionality to third part data ui
  • Adds access control for inventoryValue

@cephaschapa cephaschapa requested a review from lemilonkh March 4, 2024 18:06
Copy link

github-actions bot commented Mar 4, 2024

LCOV of commit 0830e31 during Push Web app to GHCR and deploy to EKS #798

Summary coverage rate:
  lines......: 61.8% (5482 of 8876 lines)
  functions..: 87.9% (239 of 272 functions)
  branches...: 88.9% (352 of 396 branches)

Files changed coverage rate: n/a

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.30%. Comparing base (fda8341) to head (0830e31).
Report is 88 commits behind head on develop.

❗ Current head 0830e31 differs from pull request most recent head cfa2eee. Consider uploading reports for the commit cfa2eee to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #355      +/-   ##
===========================================
+ Coverage    61.27%   61.30%   +0.02%     
===========================================
  Files           61       60       -1     
  Lines         9232     8876     -356     
  Branches        91       88       -3     
===========================================
- Hits          5657     5441     -216     
+ Misses        3570     3432     -138     
+ Partials         5        3       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lemilonkh
Copy link
Contributor

Can you also write a test for the new functionality in UserService? Might make sense to add a new test suite for it. Maybe we'll do it once the Jest PR is merged though?

@cephaschapa cephaschapa merged commit 79c9808 into develop Mar 19, 2024
3 checks passed
@cephaschapa cephaschapa deleted the feature/disconnect-third-party-data branch March 19, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants