Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

663 aggregate spatial can not be used as input to vector to raster 1 #267

Conversation

JeroenVerstraelen
Copy link
Contributor

No description provided.

Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some quick notes

openeo_driver/datacube.py Outdated Show resolved Hide resolved
openeo_driver/datacube.py Show resolved Hide resolved
openeo_driver/datacube.py Outdated Show resolved Hide resolved
openeo_driver/datacube.py Outdated Show resolved Hide resolved
openeo_driver/save_result.py Show resolved Hide resolved
openeo_driver/datacube.py Show resolved Hide resolved
openeo_driver/save_result.py Outdated Show resolved Hide resolved
openeo_driver/save_result.py Outdated Show resolved Hide resolved
openeo_driver/save_result.py Outdated Show resolved Hide resolved
@soxofaan
Copy link
Member

soxofaan commented Mar 4, 2024

overall I think there should be more unit test coverage because there are a lot of small details to this

@JeroenVerstraelen JeroenVerstraelen merged commit c8f491f into master Mar 6, 2024
1 check passed
@JeroenVerstraelen JeroenVerstraelen deleted the 663-aggregate_spatial-can-not-be-used-as-input-to-vector_to_raster-1 branch March 6, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aggregate_spatial can not be used as input to vector_to_raster
2 participants