pull job action away from track_statuses #711
Open
+32
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soxofaan does this design match with what we discussed yesterday? |
soxofaan
reviewed
Jan 22, 2025
| @@ -206,6 +206,7 @@ def __init__( | |||
| poll_sleep: int = 60, | |||
| root_dir: Optional[Union[str, Path]] = ".", | |||
| *, | |||
| download: Optional[bool] = True, | |||
There was a problem hiding this comment.
I think this feature to disable download can be a different feature request and PR
| metadata_path = self.get_job_metadata_path(job.job_id) | ||
|
|
||
| self.ensure_job_dir_exists(job.job_id) | ||
| job.get_results().download_files(target=job_dir) | ||
| if self._download: |
There was a problem hiding this comment.
FYI: I think this if can be moved to the top of this function: if you don't want to download, nothing has to happen here
| if previous_status in {"created", "queued"} and new_status == "running": | ||
| stats["job started running"] += 1 | ||
| active.loc[i, "running_start_time"] = rfc3339.utcnow() | ||
| jobs_error.append((the_job, active.loc[i])) | ||
|
|
||
| if new_status == "canceled": | ||
| stats["job canceled"] += 1 | ||
| self.on_job_cancel(the_job, active.loc[i]) |
There was a problem hiding this comment.
jobs_canceled is not handled here
|
|
||
| if new_status == "canceled": | ||
| stats["job canceled"] += 1 | ||
| self.on_job_cancel(the_job, active.loc[i]) | ||
|
|
||
| if previous_status in {"created", "queued"} and new_status == "running": |
There was a problem hiding this comment.
did you move this code block for a reason? I'm not sure that's necessary
| @@ -540,6 +542,16 @@ def _job_update_loop( | |||
| stats["job_db persist"] += 1 | |||
| total_added += 1 | |||
|
|
|||
| # Act on jobs | |||
| for job, metadata in jobs_error: | |||
There was a problem hiding this comment.
metadata might be a bit confusing. I think we use something like row elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.