[svdconv] add protection handling to SvdItem::CopyItem and add SvdItem::SetProtection #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds protection handling to
SvdItem::CopyItem. Currently, if anSvdItemis copied (e.g.,dimorderivedFrom), its protection is not being copied (different from the other register propertiessize,access,resetValue, andresetMask). As a result,SvdItem::GetEffectiveProtectionalways returnsUNDEFfor inherited (derivedFrom) or dimensioned (dim)SvdItems. In my opinion, there is no reason for that, but please let me know if there is a specific reason (@thorstendb-ARM ?).I'm currently working on SVD test cases for cmsis-svd and SVDSuite and am trying to figure out how the inheritance of the protection rights should be handled. I'm aware that the protection is currently not really used in
svdconv, but I believe it should be handled correctly if already implemented.