Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr] Fix Bvendor handling (#995) #1680

Merged

Conversation

grasci-arm
Copy link
Collaborator

@grasci-arm grasci-arm commented Aug 1, 2024

Bvendor is an unrestricted string and must be handled accordingly.
It should not be confused with Dvendor that uses predefined values listed in Device Vendor Enum and may have alternate names remapping.

Address #1671

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.82%. Comparing base (6cdfdd7) to head (c399d55).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1680   +/-   ##
=======================================
  Coverage   63.81%   63.82%           
=======================================
  Files         162      162           
  Lines       31599    31599           
  Branches    19364    19364           
=======================================
+ Hits        20166    20167    +1     
  Misses       7530     7530           
+ Partials     3903     3902    -1     
Flag Coverage Δ
projmgr-cov 80.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 87.01% <100.00%> (+0.03%) ⬆️

Copy link

github-actions bot commented Aug 1, 2024

Test Results

    3 files     18 suites   7m 31s ⏱️
  359 tests   359 ✅ 0 💤 0 ❌
1 077 runs  1 077 ✅ 0 💤 0 ❌

Results for commit c399d55.

@brondani brondani merged commit 8cdcd1f into Open-CMSIS-Pack:main Aug 1, 2024
33 checks passed
@brondani brondani deleted the outbound/projmgr-board-vendor branch August 1, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants