Skip to content

Commit

Permalink
Initializer ProjMgrWorker boolean members
Browse files Browse the repository at this point in the history
Noticed when ProjMgrUnitTests.ExecuteGeneratorWithKey failed in CI since
m_dryRun must have been randomly true.

Contributed by STMicroelectronics

Signed-off-by: Erik MÅLLBERG <[email protected]>
  • Loading branch information
ErikMallbergSTM committed Jul 5, 2023
1 parent 43dd5e8 commit 1d32494
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions tools/projmgr/src/ProjMgrWorker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,13 @@ static const map<const string, tuple<const string, const string, const string>>
{ "IAR", {ProjMgrUtils::IAR_ELF_SUFFIX , ProjMgrUtils::IAR_LIB_PREFIX , ProjMgrUtils::IAR_LIB_SUFFIX }},
};

ProjMgrWorker::ProjMgrWorker(void) {
m_loadPacksPolicy = LoadPacksPolicy::DEFAULT;
ProjMgrWorker::ProjMgrWorker(void) :

Check warning on line 40 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / coverage

when initialized here [-Wreorder]

Check warning on line 40 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / build-swig (ubuntu-22.04, linux, amd64, csolution, always, true, true)

when initialized here [-Wreorder]

Check warning on line 40 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, linux, amd64, csolution, always, true, true)

when initialized here [-Wreorder]

Check warning on line 40 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / build (ubuntu-22.04, linux, arm64, csolution, always, false, false)

when initialized here [-Wreorder]

Check warning on line 40 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / unittest (ubuntu-22.04, linux, amd64, csolution, always, true, true)

when initialized here [-Wreorder]

Check warning on line 40 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / unittest (ubuntu-22.04, linux, arm64, csolution, always, false, false)

when initialized here [-Wreorder]
m_checkSchema(false),
m_verbose(false),
m_debug(false),
m_dryRun(false),

Check warning on line 44 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / build-swig (macos-12, darwin, amd64, csolution, publicRepo, true, true)

field 'm_dryRun' will be initialized after field 'm_loadPacksPolicy' [-Wreorder-ctor]

Check warning on line 44 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / build (macos-12, darwin, amd64, csolution, publicRepo, true, true)

field 'm_dryRun' will be initialized after field 'm_loadPacksPolicy' [-Wreorder-ctor]

Check warning on line 44 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / build (macos-12, darwin, arm64, csolution, publicRepo, false, false)

field 'm_dryRun' will be initialized after field 'm_loadPacksPolicy' [-Wreorder-ctor]

Check warning on line 44 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / unittest (macos-12, darwin, amd64, csolution, publicRepo, true, true)

field 'm_dryRun' will be initialized after field 'm_loadPacksPolicy' [-Wreorder-ctor]

Check warning on line 44 in tools/projmgr/src/ProjMgrWorker.cpp

View workflow job for this annotation

GitHub Actions / unittest (macos-12, darwin, arm64, csolution, publicRepo, false, false)

field 'm_dryRun' will be initialized after field 'm_loadPacksPolicy' [-Wreorder-ctor]
m_loadPacksPolicy(LoadPacksPolicy::DEFAULT)
{
RteCondition::SetVerboseFlags(0);
}

Expand Down

0 comments on commit 1d32494

Please sign in to comment.