Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbuild] Fix custom tmpdir retrieval #270

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

brondani
Copy link
Collaborator

Complementary to #262

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

Test Results

  4 files  ±0   48 suites  ±0   4s ⏱️ ±0s
222 tests ±0  222 ✅ ±0  0 💤 ±0  0 ❌ ±0 
888 runs  ±0  888 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 06d5861. ± Comparison against base commit d715d2f.

Copy link

codeclimate bot commented Jul 12, 2024

Code Climate has analyzed commit 06d5861 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 66.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.9% (0.0% change).

View more on Code Climate.

@brondani brondani marked this pull request as ready for review July 12, 2024 11:56
@brondani brondani requested a review from soumeh01 July 12, 2024 11:56
Copy link
Collaborator

@soumeh01 soumeh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit f45f55e into main Jul 15, 2024
16 checks passed
@brondani brondani deleted the cbuild-fix-tmpdir-retrieval branch July 15, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants