Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align selection of first build & target type when cbuild-set doesn't exist #264

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Jul 4, 2024

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@soumeh01 soumeh01 changed the title Align selection of first build & target type when cbuild-set doesn't … Align selection of first build & target type when cbuild-set doesn't exist Jul 4, 2024
@soumeh01 soumeh01 requested a review from brondani July 4, 2024 07:51
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Test Results

  4 files  ± 0   48 suites  ±0   5s ⏱️ -1s
222 tests  -  3  222 ✅  -  3  0 💤 ±0  0 ❌ ±0 
888 runs   - 12  888 ✅  - 12  0 💤 ±0  0 ❌ ±0 

Results for commit baddfa0. ± Comparison against base commit 111267e.

This pull request removes 3 tests.
github.com/Open-CMSIS-Pack/cbuild/v2/pkg/utils ‑ TestParseCsolutionFile
github.com/Open-CMSIS-Pack/cbuild/v2/pkg/utils ‑ TestParseCsolutionFile/test_csolution_file_parsing
github.com/Open-CMSIS-Pack/cbuild/v2/pkg/utils ‑ TestParseCsolutionFile/test_input_file_not_available

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codeclimate bot commented Jul 4, 2024

Code Climate has analyzed commit baddfa0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.1% (1.0% change).

View more on Code Climate.

@soumeh01 soumeh01 merged commit 15c0e63 into main Jul 4, 2024
16 checks passed
@soumeh01 soumeh01 deleted the cleanupSetUp branch July 4, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants