Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -S,--context-set as mandatory arg for setup command #259

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Jun 28, 2024

The change includes:

  • Making of -S, --context-set argument as mandatory for setup command
  • cbuild returning only error code 1 & 0 for fail and successful respectively
  • Setting a default value for --jobs to 8

Copy link
Contributor

github-actions bot commented Jun 28, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@soumeh01 soumeh01 requested a review from jkrech June 28, 2024 10:00
Copy link
Contributor

github-actions bot commented Jun 28, 2024

Test Results

  4 files  ±0   48 suites  ±0   4s ⏱️ ±0s
207 tests ±0  207 ✅ ±0  0 💤 ±0  0 ❌ ±0 
828 runs  ±0  828 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b19e3fc. ± Comparison against base commit e2306c5.

♻️ This comment has been updated with latest results.

pkg/errutils/errutils.go Outdated Show resolved Hide resolved
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment below.

Copy link

codeclimate bot commented Jun 28, 2024

Code Climate has analyzed commit b19e3fc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.7% (-1.3% change).

View more on Code Climate.

@jkrech jkrech self-requested a review June 28, 2024 10:42
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit ec3a426 into main Jun 28, 2024
15 of 16 checks passed
@jkrech jkrech deleted the updateSetup branch June 28, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants