Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbuild] Improve CMake --target handling in cbuild2cmake mode #256

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

brondani
Copy link
Collaborator

Fix regression reported in #244
If no --context is specified, run cmake build target all to trigger executes steps

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Test Results

  4 files  ± 0   48 suites  ±0   5s ⏱️ -1s
211 tests + 3  211 ✅ + 3  0 💤 ±0  0 ❌ ±0 
844 runs  +12  844 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit c3a618b. ± Comparison against base commit 340bafb.

♻️ This comment has been updated with latest results.

@brondani brondani force-pushed the cbuild-rework-target-option branch from 2363fc7 to c3a618b Compare June 26, 2024 11:09
Copy link

codeclimate bot commented Jun 26, 2024

Code Climate has analyzed commit c3a618b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 78.4% (0.2% change).

View more on Code Climate.

@brondani brondani marked this pull request as ready for review June 26, 2024 11:15
@brondani brondani requested a review from soumeh01 June 26, 2024 11:15
@brondani brondani merged commit d8ddc5b into main Jun 27, 2024
16 checks passed
@brondani brondani deleted the cbuild-rework-target-option branch June 27, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants