fix: audit issues quicktype #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJunyuan
approved these changes
Jan 17, 2025
|
🎉 This PR is included in version 6.9.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
quicktypeis used to generate typescript types from our v2.0 and v3.0 schemasquicktypehas dependencies that are causing audit issuesquicktypeto a the latest major will break existing types where their corresponding schema definition is ofadditionalProperties: true-{ [property: string]: any }is added, and these update types now will not work as expected if they are used in any type operation that useskeyof(ieOmit)Changes
quicktypeIssues
What are the related issues or stories?