Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: digest should handle falsy values correctly #273

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: digest should handle falsy values correctly #273

merged 1 commit into from
Apr 11, 2024

Conversation

HJunyuan
Copy link
Member

@HJunyuan HJunyuan commented Apr 11, 2024 •
edited
Loading

Summary

digestCredential() did not deem falsy values (e.g. false, 0, etc.) as "visible data"

Changes

Add an explicit check for !== undefined to allow falsy values

Special thanks to @phanshiyu for highlighting this

@HJunyuan HJunyuan requested a review from phanshiyu April 11, 2024 03:36
@HJunyuan HJunyuan merged commit 70059b2 into master Apr 11, 2024
6 checks passed
@HJunyuan HJunyuan deleted the fix/falsy-values branch April 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanshiyu phanshiyu phanshiyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HJunyuan @phanshiyu