Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[music]: fix cosmetics log not showing disabled sequences #2186

Merged
merged 1 commit into from
Mar 9, 2024
Merged

fix[music]: fix cosmetics log not showing disabled sequences #2186

merged 1 commit into from
Mar 9, 2024

Conversation

TreZc0
Copy link
Member

@TreZc0 TreZc0 commented Mar 8, 2024

After a recent change, you provide a list of sequences via cosmetics plando, which is used as base for online music patching.
However, this was not compatible with actively disabling sequences. This PR fixes that, all while maintaining offline functionality.

@TreZc0 TreZc0 added the Component: Plandomizer Plandomizer library and functionality label Mar 8, 2024
@fenhl fenhl added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Component: Cosmetics Affects the patching of cosmetics and removed Component: Plandomizer Plandomizer library and functionality labels Mar 9, 2024
@fenhl fenhl added this to the 8.1 milestone Mar 9, 2024
@fenhl fenhl removed the Status: Needs Testing Probably should be tested label Mar 9, 2024
@fenhl
Copy link
Collaborator

fenhl commented Mar 9, 2024

Reviewed by @Cuphat.

@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label Mar 9, 2024
@fenhl fenhl merged commit 726e5be into OoTRandomizer:Dev Mar 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cosmetics Affects the patching of cosmetics Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants