Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify error message for unshuffled starting trade item #2159

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Jan 8, 2024

Motivated by yesterday's conversation in #setup-support, this PR edits the error message shown when a trade sequence item is included as a starting item but not included in the set of shuffled trade items. Previously, the error message only suggested to remove the item from the starting items, but another way to fix the error is to add it to the shuffled trade items. The new error message gives both options.

@fenhl fenhl added the Component: Documentation Affects user-facing help messages or public API docs label Jan 8, 2024
@fenhl fenhl added the Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release label Feb 15, 2024
@fenhl fenhl added this to the next milestone Mar 19, 2024
@fenhl fenhl removed the Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release label Mar 20, 2024
@fenhl fenhl merged commit 4f942b7 into OoTRandomizer:Dev Mar 20, 2024
3 checks passed
@fenhl fenhl deleted the starting-trade-item-error branch March 20, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Affects user-facing help messages or public API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant