Custom voice pack improvements #2143
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added
Type: Enhancement
fenhl
added
Status: Needs Review
rrealmuto
force-pushed
the
custom_voice_packs
branch
2 times, most recently
from
ef126dd to
c510c75
Compare
rrealmuto
force-pushed
the
custom_voice_packs
branch
from
d25301d to
9b89761
Compare
rrealmuto
force-pushed
the
custom_voice_packs
branch
from
01b264e to
7c058cc
Compare
rrealmuto
force-pushed
the
custom_voice_packs
branch
2 times, most recently
from
5addf34 to
7d6fdbb
Compare
rrealmuto
force-pushed
the
custom_voice_packs
branch
from
7d6fdbb to
807fcbc
Compare
…allow negative offsets. Probably need to scrub this a bit more
…sing direct_bank format
…ermanent bank size based on new bank0
…smetic log errors and don't crash if a bank is missing sample data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves and streamlines the process of creating custom voice packs for OOTR.
Currently, custom voice packs are fairly limited in terms of what you can do. They only support the vanilla sampling rate and must not exceed the original SFX length. The workflow is also a bit cumbersome and the audio files need to be manually converted to binary files to inject into the ROM using some 3rd party tools.
This PR removes all restrictions on custom voices by using the improved audio system from the MMR Music PR #2044 . Audio files must simply be mastered in .AIFF format and converted to .AIFC (the file format used by the N64) using the original N64 utility vadpcm_enc with the vanilla code book file. Will eventually write up a full procedure on creating custom voice packs in this format, but it is quite a bit easier than the current method.
Leaving this as draft until MMR music gets merged but just wanted to put it on people's radar.
Still to do: