-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-game input viewer #2138
In-game input viewer #2138
Conversation
I want to point out that the OoT Speedrun rules state: |
I'll bring it to the dev-race-mods channel ! |
This is really cool! Hopefully we can find a solution where, if necessary, the viewer is disabled for race seeds and that's acceptable to the race mods. |
@GSKirox Could you rebase this please? I can give this a proper review then. |
725aa25
to
a766564
Compare
Rebased and pushed, sorry for the delay, i don't check github too often these days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened GSKirox#5 with some code style fixes. This looks good otherwise.
Code style fixes for in-game input viewer
Thanks #dev-public-talk for making me check github sometimes... |
This new cosmetic setting enables an in-game input viewer for the stick X/Y positions and all button presses except Start.
Dolphin screenshot :
The icons used are the ones in the tutorial textboxes, which is why sadly Start is missing since they never needed one.
D-Pad inputs re-uses the C button ones, just colored differently.
The colors used for the A/B/C buttons will match their corresponding cosmetic.
The position used is almost certainly out of the CRT safe range, but this is an optional and not important rando information, and it's hard to find room on the screen without it being too distracting 😅