Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-game input viewer #2138

Merged
merged 3 commits into from
Mar 19, 2024
Merged

In-game input viewer #2138

merged 3 commits into from
Mar 19, 2024

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Nov 12, 2023

This new cosmetic setting enables an in-game input viewer for the stick X/Y positions and all button presses except Start.
Dolphin screenshot :
inputviewer

The icons used are the ones in the tutorial textboxes, which is why sadly Start is missing since they never needed one.
D-Pad inputs re-uses the C button ones, just colored differently.
The colors used for the A/B/C buttons will match their corresponding cosmetic.

The position used is almost certainly out of the CRT safe range, but this is an optional and not important rando information, and it's hard to find room on the screen without it being too distracting 😅

@fenhl fenhl added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Component: Cosmetics Affects the patching of cosmetics labels Nov 12, 2023
@r0bd0g
Copy link

r0bd0g commented Nov 12, 2023

I want to point out that the OoT Speedrun rules state:
"Adapters and input displays are not allowed to give you more information than looking at an unmodified controller (so no exact values, ess range indicators, etc)."

@GSKirox
Copy link
Collaborator Author

GSKirox commented Nov 12, 2023

I'll bring it to the dev-race-mods channel !

@cjohnson57 cjohnson57 added Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Nov 13, 2023
@cjohnson57
Copy link
Collaborator

This is really cool! Hopefully we can find a solution where, if necessary, the viewer is disabled for race seeds and that's acceptable to the race mods.

SettingsList.py Outdated Show resolved Hide resolved
@fenhl
Copy link
Collaborator

fenhl commented Feb 15, 2024

@GSKirox Could you rebase this please? I can give this a proper review then.

@GSKirox
Copy link
Collaborator Author

GSKirox commented Feb 23, 2024

Rebased and pushed, sorry for the delay, i don't check github too often these days.

Copy link
Collaborator

@fenhl fenhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened GSKirox#5 with some code style fixes. This looks good otherwise.

@fenhl fenhl added Status: Waiting for Author Changes or response requested and removed Status: Needs Review Someone should be looking at it labels Feb 29, 2024
Code style fixes for in-game input viewer
@fenhl fenhl removed the Status: Waiting for Author Changes or response requested label Mar 7, 2024
@GSKirox
Copy link
Collaborator Author

GSKirox commented Mar 7, 2024

Thanks #dev-public-talk for making me check github sometimes...
Again sorry for the delay.

@fenhl fenhl added Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release and removed Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Mar 7, 2024
@fenhl fenhl added this to the next milestone Mar 19, 2024
@fenhl fenhl removed the Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release label Mar 19, 2024
@fenhl fenhl merged commit 5b90903 into OoTRandomizer:Dev Mar 19, 2024
3 checks passed
@GSKirox GSKirox deleted the input_viewer branch March 20, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Component: Cosmetics Affects the patching of cosmetics Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants