Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More options for Chests/Pots/Crates custom textures #2096

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Sep 22, 2023

This PR adds two new options on how to apply Chests and Pots/Crates textures. Since the two are divided in 2 options already, that's 4 new options.
First option give the player finer control on which exact textures will be applied in game.
chest textures
potcrate textures
Works and will only show in the UI if Texture/Texture plus Size is selected for Chest Appearance Matches Content, and only if Texture (Match Content) is selected for Pot, Crate, & Beehive Appearance Matches Contents.

The second option makes the custom textures displayed only once the Stone of Agony is obtained.

2023-09-22.10-53-11.mp4

This option is only available for chests if Texture is selected for Chest Appearance Matches Content, and for Pots/Crates, only if Texture (Match Content) is selected.

@r0bd0g
Copy link

r0bd0g commented Sep 22, 2023

I think we've already got too many convoluted options for minute details like these. It was already pretty overwhelming.
Is it possible to take a step back and design something simpler that would still work well for most people idk.

@GSKirox
Copy link
Collaborator Author

GSKirox commented Sep 23, 2023

It's what usually happen when projects become bigger and bigger.
I wouldn't say we're at overwhelming status yet though, a beginner will certainly be but that's what the presets are for.

@cjohnson57 cjohnson57 added Type: Enhancement New feature or request Component: Setting specific to setting(s) labels Sep 23, 2023
@cjohnson57 cjohnson57 added Status: Needs Review Someone should be looking at it Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release labels Nov 11, 2023
@cjohnson57 cjohnson57 added Status: Needs Testing Probably should be tested and removed Status: Waiting for Release This PR is ready for merge, but we're holding off on it until after the next release labels Nov 14, 2023
@GSKirox GSKirox force-pushed the textures branch 2 times, most recently from 4bb7c69 to 17ef11e Compare December 2, 2023 08:05
ASM/c/chests.c Outdated Show resolved Hide resolved
Patches.py Outdated Show resolved Hide resolved
SettingsList.py Outdated Show resolved Hide resolved
SettingsList.py Outdated Show resolved Hide resolved
SettingsList.py Outdated Show resolved Hide resolved
@fenhl
Copy link
Collaborator

fenhl commented Mar 21, 2024

Is there a use case for having separate settings for chests vs pots/crates? Seems unlikely to me that someone would want to configure them differently, so I think they should be combined into one setting once we have enable relations (#1827).

@GSKirox
Copy link
Collaborator Author

GSKirox commented Apr 2, 2024

Rebased and applied code suggestions.

Patches.py Outdated Show resolved Hide resolved
Patches.py Outdated Show resolved Hide resolved
SettingsList.py Outdated Show resolved Hide resolved
SettingsList.py Outdated Show resolved Hide resolved
SettingsList.py Outdated Show resolved Hide resolved
SettingsList.py Outdated Show resolved Hide resolved
@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label Apr 3, 2024
@cjohnson57 cjohnson57 merged commit 5a585dd into OoTRandomizer:Dev Apr 22, 2024
3 checks passed
@fenhl fenhl added this to the next milestone Apr 22, 2024
@GSKirox GSKirox deleted the textures branch October 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Setting specific to setting(s) Status: Needs Testing Probably should be tested Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants