Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB-10224 Fixed the deployment of key vault diagnostic settings when monitoring is enabled #70

Merged

Conversation

viktor-ribchev
Copy link
Contributor

Description

Fixed the deployment of key vault diagnostic settings when monitoring is enabled

Related Issues

GDB-10224

Changes

Introduced new variable create_key_vault_diagnostic_settings

Screenshots (if applicable)

N/A

Checklist

  • I have tested these changes thoroughly.
  • My code follows the project's coding style.
  • I have added appropriate comments to my code, especially in complex areas.
  • All new and existing tests passed locally.

@viktor-ribchev viktor-ribchev requested review from mihailradkov and a user May 9, 2024 06:38
@viktor-ribchev viktor-ribchev force-pushed the GDB-10224_fix_deployment_vault_diagnostic_settings branch 2 times, most recently from 66f5566 to 52548ca Compare May 9, 2024 06:39
main.tf Outdated Show resolved Hide resolved
@viktor-ribchev viktor-ribchev force-pushed the GDB-10224_fix_deployment_vault_diagnostic_settings branch from 52548ca to 8a4083f Compare May 9, 2024 06:54
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…monitoring is enabled

updated the CHANGELOG.md
@viktor-ribchev viktor-ribchev force-pushed the GDB-10224_fix_deployment_vault_diagnostic_settings branch from 8a4083f to 4b62165 Compare May 9, 2024 12:30
@viktor-ribchev viktor-ribchev merged commit 3b43a74 into main May 9, 2024
3 checks passed
@viktor-ribchev viktor-ribchev deleted the GDB-10224_fix_deployment_vault_diagnostic_settings branch May 9, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants