-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues related to single node deployment #61
Merged
viktor-ribchev
merged 2 commits into
main
from
GDB-10523_fix_issues_with_single_node_deployment
Jul 17, 2024
Merged
Fixed issues related to single node deployment #61
viktor-ribchev
merged 2 commits into
main
from
GDB-10523_fix_issues_with_single_node_deployment
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktor-ribchev
force-pushed
the
GDB-10523_fix_issues_with_single_node_deployment
branch
2 times, most recently
from
July 16, 2024 06:50
ac18844
to
42d4598
Compare
ghost
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
viktor-ribchev
force-pushed
the
GDB-10523_fix_issues_with_single_node_deployment
branch
from
July 16, 2024 06:57
22f4461
to
d4139df
Compare
mihailradkov
requested changes
Jul 16, 2024
viktor-ribchev
force-pushed
the
GDB-10523_fix_issues_with_single_node_deployment
branch
3 times, most recently
from
July 16, 2024 10:19
1f2bbb8
to
9611139
Compare
viktor-ribchev
force-pushed
the
GDB-10523_fix_issues_with_single_node_deployment
branch
from
July 17, 2024 06:15
6f04d4b
to
b0425df
Compare
* Removed unused resource * Fixed graphdb.properties values for single node deployment * Removed calculation of `lb_tls_enabled` in the LB module as it is calculated in the main.tf * Replaced `monitoring_route53_healtcheck_fqdn_url` with `graphdb_external_address` as it is the same URL. * Removed `monitoring_route53_healtcheck_fqdn_url` variable * Introduced new variable `graphdb_external_address` * Moved proxy config file to be created only when node count > 1 * Removed port from graphdb.external-
viktor-ribchev
force-pushed
the
GDB-10523_fix_issues_with_single_node_deployment
branch
from
July 17, 2024 06:19
e642adb
to
4550732
Compare
mihailradkov
approved these changes
Jul 17, 2024
viktor-ribchev
deleted the
GDB-10523_fix_issues_with_single_node_deployment
branch
July 17, 2024 06:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issues related to single node deployment
Related Issues
GDB-10523
Changes
lb_tls_enabled
in the LB module as it is calculated in the main.tfmonitoring_route53_healtcheck_fqdn_url
withgraphdb_external_address
as it is the same URL.monitoring_route53_healtcheck_fqdn_url
variablegraphdb_external_address
Screenshots (if applicable)
N/A
Checklist