Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues related to single node deployment #61

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

viktor-ribchev
Copy link
Contributor

Description

Fixed issues related to single node deployment

Related Issues

GDB-10523

Changes

  • Removed unused variables
  • Fixed graphdb.properties values for single node deployment
  • Removed calculation of lb_tls_enabled in the LB module as it is calculated in the main.tf
  • Replaced monitoring_route53_healtcheck_fqdn_url with graphdb_external_address as it is the same URL.
  • Removed monitoring_route53_healtcheck_fqdn_url variable
  • Introduced new variable graphdb_external_address

Screenshots (if applicable)

N/A

Checklist

  • I have tested these changes thoroughly.
  • My code follows the project's coding style.
  • I have added appropriate comments to my code, especially in complex areas.
  • All new and existing tests passed locally.

@viktor-ribchev viktor-ribchev requested review from mihailradkov and a user July 16, 2024 06:40
@viktor-ribchev viktor-ribchev force-pushed the GDB-10523_fix_issues_with_single_node_deployment branch 2 times, most recently from ac18844 to 42d4598 Compare July 16, 2024 06:50
@viktor-ribchev viktor-ribchev self-assigned this Jul 16, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viktor-ribchev viktor-ribchev force-pushed the GDB-10523_fix_issues_with_single_node_deployment branch from 22f4461 to d4139df Compare July 16, 2024 06:57
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@viktor-ribchev viktor-ribchev force-pushed the GDB-10523_fix_issues_with_single_node_deployment branch 3 times, most recently from 1f2bbb8 to 9611139 Compare July 16, 2024 10:19
variables.tf Outdated Show resolved Hide resolved
modules/graphdb/variables.tf Show resolved Hide resolved
modules/graphdb/templates/04_gdb_conf_overrides.sh.tpl Outdated Show resolved Hide resolved
@viktor-ribchev viktor-ribchev force-pushed the GDB-10523_fix_issues_with_single_node_deployment branch from 6f04d4b to b0425df Compare July 17, 2024 06:15
* Removed unused resource
* Fixed graphdb.properties values for single node deployment
* Removed calculation of `lb_tls_enabled` in the LB module as it is calculated in the main.tf
* Replaced `monitoring_route53_healtcheck_fqdn_url` with `graphdb_external_address` as it is the same URL.
* Removed `monitoring_route53_healtcheck_fqdn_url` variable
* Introduced new variable `graphdb_external_address`
* Moved proxy config file to be created only when node count > 1
* Removed port from graphdb.external-
@viktor-ribchev viktor-ribchev force-pushed the GDB-10523_fix_issues_with_single_node_deployment branch from e642adb to 4550732 Compare July 17, 2024 06:19
@viktor-ribchev viktor-ribchev merged commit 66d7911 into main Jul 17, 2024
@viktor-ribchev viktor-ribchev deleted the GDB-10523_fix_issues_with_single_node_deployment branch July 17, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants