Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added fallback loader for non unique consulting type slugs #999

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Jan 28, 2024

Fixes #

Proposed Changes

Copy link

what-the-diff bot commented Jan 28, 2024

PR Summary

  • Environment Variable Addition
    An additional environment variable FRONTEND_REGISTRATION_DIRECTLINK_FALLBACKLOADER_ENABLED has been included to the .env.sample file. This alteration allows users to establish whether they want to activate a fallback feature when the slug isn't unique.

  • Configuration Update
    A new block of code has been added in proxy/config.js file, complementing the new feature - for registering direct links and enabling a fallback loader.

  • Interface Enhancement
    There is a new sub-object registration.directlink.fallbackLoader.enabled in the registration object of the src/globalState/interfaces/AppConfig/AppConfigInterface.ts file. This extension caters for the newly added registration feature and its enabling and disabling based on the environment variable.

  • Fallback Logic for Special Client
    Additional code was integrated in the src/utils/useUrlParamsLoader.tsx file to manage the new fallback mechanism when the slug is not unique for a special client. This helps to further ensure the uniqueness of slugs, providing more reliability to users.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-mi web-mi merged commit 96a53e1 into develop Jan 28, 2024
8 checks passed
@web-mi web-mi deleted the OB-FixRegistrationDirectLink branch January 28, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants