Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use session status for initial appointment check #985

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

janrembold
Copy link
Contributor

@janrembold janrembold requested a review from web-mi January 9, 2024 14:23
Copy link

what-the-diff bot commented Jan 9, 2024

PR Summary

  • Enhanced Code Import in Booking Component
    The updates in the import statement within the 'booking.tsx' file now include STATUS_EMPTY. This change ensures more comprehensive code handling while importing scripts.

  • Null Check Added for Session Rendering
    An additional safety layer has been built-in before rendering JSX elements in the Booking component. Now, the code will check if session is null, avoiding potential crashes and improving user experience.

  • Improved Condition Checking in AJAX Request
    The conditions for metadata[isInitialAppointment] within an AJAX request have been refined. These checks will now verify if session.session.status is STATUS_EMPTY for more accurate data management and function calls.

web-mi
web-mi previously approved these changes Jan 9, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@janrembold janrembold merged commit 8cee656 into develop Jan 10, 2024
8 checks passed
@janrembold janrembold deleted the fix/booking-initial-appointment branch January 10, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants