Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show agency logos in chat sessions if logo is available #1022

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

janrembold
Copy link
Contributor

Fixes #

Proposed Changes

@janrembold janrembold requested a review from web-mi March 8, 2024 11:09
Copy link

what-the-diff bot commented Mar 8, 2024

PR Summary

  • Addition of jotai package to the dependency list
    This change adds an important package named jotai to the list of existing package dependencies. This package aids the state management in our application, helping to manage and manipulate the shared data easily.

  • Modification of 'Header' File
    The header file of our application has been updated to use a new way to show the agency logo. Instead of retrieving the logo directly from the tenant data, it will now use a value stored in memory, called agencyLogo. This value is dependent on jotai, the package we just added. Moreover, a conditional rendering aspect has been implemented to display the logo only when the agencyLogo value is available. This improves the load speed and performance of our application's header.

  • Enhancement of 'SessionView' File
    This file has been updated to use the jotai package for managing the agency logo. We've added a new mechanism that can instantly change the logo when we wish. Additionally, this file will now retrieve the logo using a specific API and update the value stored in memory. This change makes it easy for us to manage and update the logo used in sessions. Lastly, the changes include an added function to clean up this stored logo from memory when the session ends, thus saving memory resources.

Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-mi web-mi merged commit f91e004 into develop Mar 8, 2024
8 checks passed
@web-mi web-mi deleted the feat/show-agency-logo-in-header branch March 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants