Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: agency list update registration #1014

Merged
merged 5 commits into from
Feb 28, 2024
Merged

fix: agency list update registration #1014

merged 5 commits into from
Feb 28, 2024

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Feb 28, 2024

Fixes #

Proposed Changes

Copy link

what-the-diff bot commented Feb 28, 2024

PR Summary

  • Enhancements to Consultant Registration
    We've improved how consultants sign up by modifying a core piece of code (useConsultantRegistrationData). Now, it can take into consideration two factors: consultingTypeId and topicId. Essentially, if a consultant specifies their field of expertise and topic of interest, the system will present them with a more tailored list of agencies to choose from.

  • Updates Across Components
    Our changes to the useConsultantRegistrationData have affected a few areas in our codebase. We've made the necessary modifications in ConsultingTypeAgencySelection.tsx, FormAccordion.tsx, and Login.tsx to maintain compatibility and smooth functionality.

  • Refinements to Agency Selection
    Our agency selection process for registration (useAgenciesForRegistration) is now smarter, filtering possibilities depending on the consultant's chosen field and topic of interest. This will help align agencies and consultants better, ensuring a more effective partnership.

  • Language Update for "Topic" Field
    We believe in making our platform as inclusive as possible. To this end, translations for the "topic" field have been updated across German (formal and informal) and English languages. Accessibility and clarity for global users are our priority.

@web-mi web-mi requested a review from janrembold February 28, 2024 02:24
tkuzynow
tkuzynow previously approved these changes Feb 28, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-mi web-mi merged commit ded217e into develop Feb 28, 2024
8 checks passed
@web-mi web-mi deleted the feat/OB-9486 branch February 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants