Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 504 error response #1001

Merged
merged 2 commits into from
Feb 1, 2024
Merged

feat: add 504 error response #1001

merged 2 commits into from
Feb 1, 2024

Conversation

janrembold
Copy link
Contributor

Fixes #

Proposed Changes

@janrembold janrembold requested a review from web-mi February 1, 2024 13:17
Copy link

what-the-diff bot commented Feb 1, 2024

PR Summary

  • Enhancement in Error Handling
    Introduced a new error, FETCH_ERRORS.GATEWAY_TIMEOUT, for handling gateway timeout situations in apiPatchUserData.ts. This will allow our system to understand and categorize the problem when the gateway does not respond in a timely manner.

  • Amendment to Fetch Data Error Object
    The FETCH_ERRORS object in the fetchData.ts file has been updated to include FETCH_ERRORS.GATEWAY_TIMEOUT. This addition will increase the range of errors that our application can identify and handle appropriately.

  • Promise Rejection Condition
    A new condition was introduced in fetchData.ts to reject a promise if the response status is 504 (i.e., gateway timeout) and if the responseHandling array includes a FETCH_ERRORS.GATEWAY_TIMEOUT error. This enhancement will make our system more robust in handling certain server-side issues, ensuring a smoother user experience.

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-mi web-mi merged commit a7783e2 into develop Feb 1, 2024
8 checks passed
@web-mi web-mi deleted the feat/add-504-error branch February 1, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants