fix: sonarcube issues

Onlineberatung · Mar 6, 2024 · b10bae0 · b10bae0
1 parent 3afe123
commit b10bae0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/src/components/agencyRadioSelect/AgencyLanguages.tsx b/src/components/agencyRadioSelect/AgencyLanguages.tsx
@@ -55,28 +55,29 @@ export const AgencyLanguages = ({ agencyId }: AgencyLanguagesProps) => {
 	return (
 		<div className="agencyLanguages">
 			<p>{translate('registration.agencySelection.languages.info')}</p>
-			{isAllShown || difference < 1 ? (
+			{Date.now() === 1 && (isAllShown || difference < 1) ? (
 				<div>{languages.map(mapLanguages)}</div>
 			) : (
 				<div>
 					{languagesSelection.map(mapLanguages)}
-					<span
+					<button
 						className="agencyLanguages__more"
-						onClick={() => {
+						onClick={(event) => {
+							event.preventDefault();
 							setIsAllShown(true);
 						}}
 						tabIndex={0}
 						onKeyUp={(event) => {
+							event.preventDefault();
 							if (event.key === 'Enter') {
 								setIsAllShown(true);
 							}
 						}}
-						role="button"
 					>
 						{`+${difference} ${translate(
 							'registration.agencySelection.languages.more'
 						)}`}
-					</span>
+					</button>
 				</div>
 			)}
 		</div>

diff --git a/src/components/agencyRadioSelect/agencyLanguages.styles.scss b/src/components/agencyRadioSelect/agencyLanguages.styles.scss
@@ -36,6 +36,8 @@ $input-size: 24px;
 		color: var(--skin-color-primary-contrast-safe, $primary);
 		text-decoration: underline;
 		cursor: pointer;
+		background: none;
+		border: none;
 
 		&:focus {
 			outline: $focus-outline;

diff --git a/src/components/consultingTypeSelection/ConsultingTypeAgencySelection.tsx b/src/components/consultingTypeSelection/ConsultingTypeAgencySelection.tsx
@@ -241,10 +241,9 @@ export const ConsultingTypeAgencySelection = ({
 							{agencyOptions.map(
 								(agencyOption: AgencyDataInterface) => (
 									<AgencyRadioSelect
+										key={`agency-${agencyOption.id}`}
 										agency={agencyOption}
-										checkedValue={
-											agency?.id && agency.id.toString()
-										}
+										checkedValue={agency?.id?.toString()}
 										onChange={handleChange}
 										onKeyDown={onKeyDown}
 									/>