chore: upgrade to spring boot 2.6.X #115
Conversation
|
| <relativePath/> <!-- lookup parent from repository --> | ||
| </parent> | ||
|
|
||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> |
There was a problem hiding this comment.
hehe I think this whitespace is not needed ;)
| <scope>test</scope> | ||
| <version>${powermock-module-junit4.version}</version> |
There was a problem hiding this comment.
you could also remove the proberties for the not used dependencies
| consultingTypeLoader, "consultingTypeRepositoryService", consultingTypeRepositoryService); | ||
| } | ||
|
|
||
| @Test | ||
| public void test_Should_Fail_WhenMethodInitDoesNotHavePostConstructAnnotation() | ||
| void test_Should_Fail_WhenMethodInitDoesNotHavePostConstructAnnotation() |
There was a problem hiding this comment.
I don't know it by heart right now, but now some test methods are public others are package-private. Shouldn't we standardise this more? Or what is the pattern?
There was a problem hiding this comment.
for the tests we switched to junit5, there should be no public test methods
There was a problem hiding this comment.
yes, but I saw a lot of tests using junit5 but the test mothods still public etc.
https://github.com/Onlineberatung/onlineBeratung-consultingTypeService/pull/115/files#diff-91bf97d4b3a3c619f25e6c17e009a271f185fd9342b7ae6202ceba7e7014e44b
Fixes #
Proposed Changes