-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean mt5 #419
Open
xiezipeng-ML
wants to merge
13
commits into
main
Choose a base branch
from
clean_mt5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Clean mt5 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
xiezipeng-ML
commented
Nov 4, 2022
# [bsz, tgt_len, num_heads, head_size] -> [bsz, tgt_len, num_heads * head_size] | ||
# SBP sign: [S(0), S(2)] | ||
# [S(0), S(2)] x [B, S(0)] = [S(0), P] -> [S(0), B] | ||
context = flow._C.transpose(context, perm=(2, 0, 1, 3)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
关于今天提到的这里有个transpose操作的原因:
attention_scores, value = flow._C.fused_self_attention(...)
,这个fused_self_attention返回的tensor的shape是attention_scores:[batch_size, num_head, seq_len1, seq_len2]以及value:[bsz, num_head, seq_len, head_size],所以这里0维就是batch_size- 然后这里的context是由context = flow.matmul(attention_weights, value)得到,所以context的shape是 [bsz, num_head, seq_len, head_size],所以最后需要有这个transpose的操作,没改之前也有transpose的操作:
context = context.transpose(1, 2)
,只不过现在交换了3个维度( context = flow._C.transpose(context, perm=(2, 0, 1, 3)))
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean mt5,默认fuse_multihead_att和fuse_softmax,注释了model_type='t5'相关内容