-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop #1515
Closed
Closed
drop #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[3.X.X] Add Privacy Manifest
Release 3.12.8
* Added the 2 existing Privacy Manifests to targets `OneSignalFramework` and `OneSignalExtension` * This is needed for SDK consumers to get the privacy manifests included in their report.
* Apple docs has called out all 4 player model modules in their "SDKs that require a privacy manifest and signature" (https://developer.apple.com/support/third-party-SDK-requirements/) - OneSignal - OneSignalCore - OneSignalExtension - OneSignalOutcomes * Since we are making a change to the other 2 existing manifest files, let's add manifest files for all the frameworks in case we may be required to update the player model SDK again due to them missing from Core and Outcomes
* Apparently `NSPrivacyCollectedDataTypes` needs to be in the privacy manifest for Core even though the framework doesn't use any. * The generated report would say "Missing an expected key: 'NSPrivacyCollectedDataTypes' YourApp.app/Frameworks/OneSignalCore.framework/PrivacyInfo.xcprivacy"
…fests [3.x.x] Update privacy manifests and add 2 more
OneSignalCore.xcframework OneSignalExtension.xcframework OneSignalOutcomes.xcframework OneSignal.xcframework
Release 3.12.9
* openURL: is completely deprecated on ios 18, so replace with the updated openURL:options:completionHandler:
* `macos-latest` recently migrated from macos-12 to macos-14 Arm64, the latter of which does not ship with swiftlint * `macos-latest-large` is also a macos-14 image and does ship with swiftlint
Privacy manifests update User Defaults API reason to include app groups, extensions, clips Previously: CA92.1 - Declare this reason to access user defaults to read and write information that is only accessible to the app itself. Now: 1C8F.1 - Declare this reason to access user defaults to read and write information that is only accessible to the apps, app extensions, and App Clips that are members of the same App Group as the app itself.
[3.x.x] Replace deprecated openURL method
…s_user_defaults [3.x.x] Privacy manifests - User Defaults API reason to include app groups
This reverts commit e5692c9.
Release 3.12.10
* Force push is not necessary * xcodebuild list seems leftover from testing
[3.x.x] Add release workflow github action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update example app icon to use new OneSignal logo.
Motivation
Requested by design, since we use the example app to build test apps, let's update the logo to the new OneSignal logo.
Scope
Example app only
Before and after:
This change is