Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop #1515

Closed
wants to merge 34 commits into from
Closed

drop #1515

wants to merge 34 commits into from

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Nov 14, 2024

Description

One Line Summary

Update example app icon to use new OneSignal logo.

Motivation

Requested by design, since we use the example app to build test apps, let's update the logo to the new OneSignal logo.

Scope

Example app only

Before and after:

Screenshot 2024-11-14 at 9 46 22 AM


This change is Reviewable

emawby and others added 30 commits January 16, 2024 11:25
* Added the 2 existing Privacy Manifests to targets `OneSignalFramework` and `OneSignalExtension`
* This is needed for SDK consumers to get the privacy manifests included in their report.
* Apple docs has called out all 4 player model modules in their "SDKs that require a privacy manifest and signature" (https://developer.apple.com/support/third-party-SDK-requirements/)
- OneSignal
- OneSignalCore
- OneSignalExtension
- OneSignalOutcomes

* Since we are making a change to the other 2 existing manifest files, let's add manifest files for all the frameworks in case we may be required to update the player model SDK again due to them missing from Core and Outcomes
* Apparently `NSPrivacyCollectedDataTypes` needs to be in the privacy manifest for Core even though the framework doesn't use any.
* The generated report would say "Missing an expected key: 'NSPrivacyCollectedDataTypes' YourApp.app/Frameworks/OneSignalCore.framework/PrivacyInfo.xcprivacy"
…fests

[3.x.x] Update privacy manifests and add 2 more
OneSignalCore.xcframework
OneSignalExtension.xcframework
OneSignalOutcomes.xcframework
OneSignal.xcframework
* openURL: is completely deprecated on ios 18, so replace with the updated openURL:options:completionHandler:
* `macos-latest` recently migrated from macos-12 to macos-14 Arm64, the latter of which does not ship with swiftlint
* `macos-latest-large` is also a macos-14 image and does ship with swiftlint
Privacy manifests update User Defaults API reason to include app groups, extensions, clips

Previously:
CA92.1 - Declare this reason to access user defaults to read and write information that is only accessible to the app itself.

Now:
1C8F.1 - Declare this reason to access user defaults to read and write information that is only accessible to the apps, app extensions, and App Clips that are members of the same App Group as the app itself.
[3.x.x] Replace deprecated openURL method
…s_user_defaults

[3.x.x] Privacy manifests - User Defaults API reason to include app groups
nan-li added 4 commits October 7, 2024 15:19
* Force push is not necessary
* xcodebuild list seems leftover from testing
[3.x.x] Add release workflow github action
@nan-li nan-li changed the base branch from player-model-main to main November 14, 2024 17:49
@nan-li nan-li changed the title [dev app] replace app icon with new logo drop Nov 14, 2024
@nan-li nan-li closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants