Build unit tests based on main branch (user model)
#1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Had some errors
- that changed after API changed
* Commenting out any file that was failing in some way * Opt to comment out instead of deleting files.
* Motivation: encountered error with "Include of non-modular header inside framework module OneSignalCore" and crashing on start with "Library not loaded OneSignalOSCore"... * Update the following build configurations that were different between Debug & Release and Test - Skip Install - Test - changed from NO to YES - Strip Debug Symbols During Copy - Test - changed from YES to NO - Targeted Device Families - Test - iPhone to iPhone and iPad - Compatibility Version - Test - set to 1 - Current Library Version - Test - set to 1 - Dynamic Library Install Name Base - Test - changed to rpath - Runpath Search Paths - Test - updated to match - Use Compiler to Extract Swift Strings - Test - changed to YES - Defines Module - Test - changed to YES - Generate Info.plist File - Test - changed to YES to match Release and Debug - enable modules - Test - set to YES
- `OneSignalLiveActivityController.m` added to UnitTests target membership - Adds missing `OneSignalLocation.framework` and `OneSignalInAppMessages.framework` and `OneSignalNotifications.framework` to UnitTests target "Frameworks and Libraries". Split out after modularization..
- UNUserNotificationCenterOverrider was causing a crash
nan-li
requested review from
jkasten2 and
emawby
and removed request for
jkasten2
nan-li
requested review from
jkasten2,
jinliu9508,
shepherd-l and
jennantilla
emawby
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Get unit tests to build after the changes we made to the SDK going from player model to user model.
Details
Motivation
Unit tests were failing because so much of the SDK has changed, and we did not update unit tests yet.
Scope
Much of the changes in this PR is commenting out failing test files. I opted to comment out instead of deleting files or test cases.
Note that the non-failing tests may still need to be refactored since passing doesn't necessarily mean they worked.
Testing
Unit testing
Majority of tests have been removed by commenting out.
Manual testing
Unit tests now build and run.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is