Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIXES: 'Did not receive a response status from last' & Prompt displaying when disabled. #316

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

marclucraft
Copy link
Contributor

@marclucraft marclucraft commented Jul 25, 2023

Issue #311
Line 75: was const.
Line 84: tried to update const.
Changed line 75 to let

Issue #282
Uncheck 'Customize the Prompt text' (and hide section) when 'Automatically prompt new site visitors with OneSignal Slide Prompt before Native Browser Prompt (recommended)' is disabled.


This change is Reviewable

…notification sent

Line 75: was const.
Line 84: tried to update const.
Changed line 84 to let
@marclucraft
Copy link
Contributor Author

@rgomezp @emawby

Two long term issues addressed.

@marclucraft marclucraft changed the title BUG FIX: OneSignal Push: Did not receive a response status from last … BUG FIXES: 'Did not receive a response status from last' & Prompt displaying when disabled. Jul 26, 2023
@emawby emawby requested review from rgomezp and jkasten2 September 1, 2023 17:33
@marclucraft
Copy link
Contributor Author

marclucraft commented Sep 28, 2023

Can somebody approve this please? @rgomezp @jkasten2 ?

@jkasten2 jkasten2 merged commit b14d4a4 into OneSignal:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants