Skip to content

Commit

Permalink
mv docker entry .sh into docker-compose
Browse files Browse the repository at this point in the history
* Moved execution of docker-entry-point.sh out of Dockerfile
and into docker-compose.yml.
* This fixes VScode's dev inside docker continer to use this command so
the sandbox starts.
  • Loading branch information
jkasten2 committed Apr 23, 2021
1 parent e95e324 commit 0865b3f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 0 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@ FROM node:12.18.0
WORKDIR /sdk
COPY package.json .
RUN yarn

CMD ./docker/docker-entry-point.sh
7 changes: 1 addition & 6 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,12 @@ services:
volumes:
- .:/sdk:cached
- sdk-build:/sdk/build/releases

# docker for Ubuntu VM
# network_mode: "host"

# docker for mac
ports:
- published: 4001
target: 4001
- published: 4000
target: 4000

command: /bin/sh -c "./docker/docker-entry-point.sh"
# Named volumes that are persisted between docker-compose rebuilds.
# If you need to remove these volumes for some reason, run `docker-compose down -v`
volumes:
Expand Down

0 comments on commit 0865b3f

Please sign in to comment.