Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] iOS build error: No type or protocol named OSLiveActivities #732

Merged
merged 2 commits into from
May 20, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented May 20, 2024

Description

One Line Summary

Fixes iOS build error: No type or protocol named 'OSLiveActivities'

Details

Motivation

Fixes Unity iOS builds

Scope

The Unity iOS plugin bridge files require the following imports instead of being included in OneSignalFramework. OneSignalCore import was added due to LiveActivities being moved into a module in the native OneSignal iOS SDK in version 5.2.0. The swift version of the OneSignalOSCore import seems to be needed due C++ and Objective-C translation. The same issue and fix was also done previously for OSUser.

Testing

Manual testing

Tested OneSignal initialization, app build with Unity 2021.3.10f1 of the OneSignal example App on an iPhone 12 with iOS 15.5.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Fixes 'No type or protocol named OSLiveActivities ' for iOS. imports are required and order matters. Likely due to weird c++ translation behaviour with objective-c.  The same issue and fix was done for OSUser.
@shepherd-l shepherd-l merged commit 6db326a into main May 20, 2024
1 check passed
@shepherd-l shepherd-l deleted the fix/iOSLiveActivities branch May 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants