[Fix] iOS bitcode build error #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Oct 3, 2023
README.md
Outdated
| @@ -117,7 +117,9 @@ After building in Unity and exporting the XCode project follow these steps: | |||
|
|
|||
|  | |||
|
|
|||
| 6. **App Groups** should now be provisioned for you going forward for your iOS bundle id, even on clean builds. | |||
| **App Groups** should now be provisioned for you going forward for your iOS bundle id, even on clean builds. | |||
README.md
Outdated
| 6. **App Groups** should now be provisioned for you going forward for your iOS bundle id, even on clean builds. | ||
| **App Groups** should now be provisioned for you going forward for your iOS bundle id, even on clean builds. | ||
|
|
||
| 6. Make sure all **Targets** have **Enable Bitcode** set to **No** in **Build Settings**. |
There was a problem hiding this comment.
Per note above, this should be step 7.
| @@ -111,6 +111,14 @@ public class BuildPostProcessor : IPostprocessBuildWithReport { | |||
| // Add the service extension | |||
| AddNotificationServiceExtension(); | |||
|
|
|||
| // Unity Tests | |||
There was a problem hiding this comment.
This method's logic is mostly declarative vs imperative. Can we make a new method call something like DisableBitcode()?
| @@ -152,6 +160,8 @@ public class BuildPostProcessor : IPostprocessBuildWithReport { | |||
| var targetGuid = _project.GetMainTargetGuid(); | |||
| var targetName = _project.GetMainTargetName(); | |||
|
|
|||
| _project.SetBuildProperty(targetGuid, "ENABLE_BITCODE", "NO"); | |||
There was a problem hiding this comment.
This method is named AddProjectCapabilities which shouldn't touch something unrelated like bitcode. I recommend moving this to the new DisableBitcode() method I suggested above.
| @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Fixed | |||
| - Sending VSAttribution data from the editor | |||
| - iOS notifications clicked event firing if the app was cold started from clicking a notification | |||
| - iOS bitcode build error | |||
There was a problem hiding this comment.
I would state we are disabling bitcode to avoid a build error.
shepherd-l
force-pushed
the
fix/iosBitcode
branch
from
25e59a3
to
9f8aae8
Compare
emawby
approved these changes
Oct 4, 2023
shepherd-l
force-pushed
the
fix/iosBitcode
branch
from
3460436
to
2159755
Compare
jinliu9508
pushed a commit
that referenced
this pull request
Feb 23, 2024
[Fix] iOS bitcode build error
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS bitcode build error
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS bitcode build error
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS bitcode build error
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS bitcode build error
jinliu9508
pushed a commit
that referenced
this pull request
Mar 1, 2024
[Fix] iOS bitcode build error
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] iOS bitcode build error
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] iOS bitcode build error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes iOS "does not contain bitcode" build error by disabling bitcode
Details
Motivation
Prevent iOS builds from failing with default "Enable Bitcode" value and documents setting "Enable Bitcode" to "No".
Testing
Manual testing
Tested OneSignal initialization, app build with Unity 2022.3.10f1 of the OneSignal example app on a physical iPhone 12 with iOS 15.5.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is