Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clearTriggers on Android #771

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Oct 23, 2023

Description

One Line Summary

The Android native bridge will now properly handle clearTriggers.

Details

fixes #767
OneSignalInAppMessages.java was not listening to clearTriggers so an error would throw when calling clearTriggers on
an Android device.

Motivation

Fix clearTriggers

Scope

IAM triggers

Testing

Manual testing

tested on pixel 7

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby force-pushed the fix/clearTriggers_on_android branch 2 times, most recently from 004b6b3 to 60979f6 Compare October 23, 2023 17:15
@emawby emawby linked an issue Oct 23, 2023 that may be closed by this pull request
3 tasks
@emawby emawby force-pushed the fix/clearTriggers_on_android branch from 60979f6 to c6b8e94 Compare October 23, 2023 19:45
@emawby emawby force-pushed the fix/clearTriggers_on_android branch from 0fade19 to 45287e8 Compare October 23, 2023 19:58
@emawby emawby merged commit b5fbd14 into user_model/main Oct 24, 2023
1 of 2 checks passed
@emawby emawby deleted the fix/clearTriggers_on_android branch October 24, 2023 18:51
@jennantilla jennantilla mentioned this pull request Nov 14, 2023
nan-li pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: In Flutter Adroid getting error when calling .clearTrigger()
2 participants