Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Player Model] Fix notification permission compile error #1933

Merged

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Dec 6, 2023

Description

One Line Summary

Fix a compile error due to a syntax error introduced in PR #1848.

Details

Also cleaned up some warnings related to an unneeded annotation and scoping to private.

Motivation

Fix compile error so we can release the fix from PR #1848 and so future release can be made.

Scope

Only fixing issues related to NotificationPermissionController.supportsNativePrompt.
Fixes #1930

Testing

Unit testing

Manual testing

Tested on Android 14 emulator, ensure it prompts for notifications.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
    • pre-existing test failure "uses-sdk:minSdkVersion 17 cannot be smaller than version 19 declared in library [com.google.firebase:firebase-messaging:23.0.0]"
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@jkasten2 jkasten2 merged commit 001a42e into main Dec 7, 2023
1 of 2 checks passed
@jkasten2 jkasten2 deleted the player-model/fix-notification-permission-compile-error branch December 7, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: I cant get to compile with the last commit on main branch ?
2 participants