-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various tweaks #407
Various tweaks #407
Conversation
Make configuration values mutable
Fallback on agency name if longName unavailable for RouteStopsViewController
Added OBAImageViewConfiguration Moved OBALabelConfiguration into own file
Increases bottom edge padding when first loading trip polyline
Fixes a OneBusAway#391 — OBAListView iOS 14 list regression
Fixes OneBusAway#354 — TodayView “NOW” is ellipsized Add DepartureTimeBadge view previews
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great! Can you take a look at the CI failure? Looks like a legit issue as opposed to spurious noise.
Training wheels for CI, which uses Swift 5.3, not 5.4.
Fixed in fc9d810, seems to be a Xcode 12.4 Swift 5.3 "feature" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
App-wide
StopViewModel
instances (MapFloatingPanelController
andRecentStopsViewController
)TripViewController
DRY
StopViewModel
RecentStopViewModel
Stop
instance in favor of the Stop's ID.Other
Tech
OBAImageViewConfiguration
for configuring a UIListContentConfiguration's image viewTripSegmentView