Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tweaks #407

Merged
merged 13 commits into from
Jul 5, 2021
Merged

Various tweaks #407

merged 13 commits into from
Jul 5, 2021

Conversation

ualch9
Copy link
Member

@ualch9 ualch9 commented Jul 3, 2021

App-wide

  • Allow DepartureTimeBadge to resize font size to fit width (fixes TodayView “NOW” is ellipsized #354)
  • Add context menus to StopViewModel instances (MapFloatingPanelController and RecentStopsViewController)

TripViewController

DRY StopViewModel

  • Remove RecentStopViewModel
  • Removes reference to Stop instance in favor of the Stop's ID.
  • Add display route icons to stop rows
  • Don’t show stop subtitle if the routes are all empty strings Simulator Screen Shot - iPhone 12 Pro - 2021-06-27 at 10 40 40

Other

Tech

  • Adds OBAImageViewConfiguration for configuring a UIListContentConfiguration's image view
  • Adds SwiftUI view previews to TripSegmentView image

@ualch9 ualch9 requested a review from aaronbrethorst July 3, 2021 17:24
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great! Can you take a look at the CI failure? Looks like a legit issue as opposed to spurious noise.

Training wheels for CI, which uses Swift 5.3, not 5.4.
@ualch9
Copy link
Member Author

ualch9 commented Jul 5, 2021

Generally looks great! Can you take a look at the CI failure? Looks like a legit issue as opposed to spurious noise.

Fixed in fc9d810, seems to be a Xcode 12.4 Swift 5.3 "feature"

@ualch9 ualch9 requested a review from aaronbrethorst July 5, 2021 15:57
@aaronbrethorst aaronbrethorst merged commit 4737dff into OneBusAway:master Jul 5, 2021
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ualch9 ualch9 deleted the ux branch July 6, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants