Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw entity ids support #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tomershefi
Copy link

This upgrade supports GTFS files that contain entities that reference other entities which do not exist in the GTFS.
A good example maybe a stop_time entity that references a trip id that does not exist in trips.txt.
This is a very common problem because many providers supply such GTFS files.
Up until now we overcame this issue by using extensions but this is very inefficient especially in large GTFS files.

Thank you very much!

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2024

CLA assistant check
All committers have signed the CLA.

@sheldonabrown
Copy link
Member

@tomershefi can you also add a test case that demonstrates how this works?

I have a concern for the case where clients of this module expect the referential integrated to be maintained and in fact enforced. Does this PR bypass that? If so, can it be configured optionally?

@leonardehrenfried
Copy link
Collaborator

So far OBA has been my first line of defense against non-compliant GTFS feeds and it would be lovely if the referential integrity guarantees could be maintained. I would like to get an exception about this as early as possible.

@tomershefi
Copy link
Author

Hey, @sheldonabrown @leonardehrenfried
This does not interfere with the current referential integrity, and that is also why i did not add any tests. The invalid GTFS file would fail exactly as it did before.
Any code base that extends this lovely library can use this new feature as it sees fit or even not at all.

@tomershefi
Copy link
Author

Hey, @sheldonabrown @leonardehrenfried.
Any updates?

@leonardehrenfried
Copy link
Collaborator

I frankly would not be in favour of supporting invalid gtfs files. I suggest you use a clean up tool like gtfstidy before reading the feed.

@leonardehrenfried
Copy link
Collaborator

I'm not a maintainer though. @sheldonabrown is.

@tomershefi
Copy link
Author

@leonardehrenfried -
this is exactly why I need this change, to clean up & fix GTFSs
I am a developer at Moovit, we want to contribute to this project as well - where we process huge amount of GTFSs daily, using this library as well.

@sheldonabrown what do you think?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants