feat!: make signal.get reactive and add signal.getOnce
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowheart
changed the title
signal.get reactive and add signal.getOnce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In keeping with other signals libs, calls to
signal.get()should register a dependency on the got signal in reactive contexts (e.g. in atom state factories and atom selector functions). Implement that and addsignal.getOnce()for getting a node's value non-reactively. Update all our internal usages of.getaccordingly - mostly moving off of.get()'cause we never want to accidentally add edges in calls to other Zedux functions.Breaking Change
This is only a breaking change from the latest, beta version (
2.0.0-beta.0) wheresignal.get()was just added and is not reactive.Issues
#115 (almost resolves! The only things left are the
cycleevent and making event listeners not prevent destruction)