Set warningsAsErrors to true and fixed warnings

OmniSharp · May 3, 2015 · bac175c · bac175c
1 parent ca3a712
commit bac175c
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 6 deletions.
diff --git a/src/OmniSharp.Stdio/project.json b/src/OmniSharp.Stdio/project.json
@@ -1,6 +1,9 @@
 {
   "version": "1.0.0-*",
   "description": "ASP.NET 5 web server for stdio",
+  "compilationOptions": {
+      "warningsAsErrors": true
+  },
   "dependencies": {
     "Microsoft.AspNet.Hosting": "1.0.0-beta3",
     "Microsoft.AspNet.Http.Interfaces": "1.0.0-beta3",

diff --git a/src/OmniSharp/project.json b/src/OmniSharp/project.json
@@ -1,5 +1,8 @@
 {
     "version": "1.0.0-*",
+    "compilationOptions": {
+        "warningsAsErrors": true
+    },
     "dependencies": {
         "OmniSharp.Stdio": "1.0.0-*",
         "Kestrel": "1.0.0-beta3",

diff --git a/tests/OmniSharp.Stdio.Tests/project.json b/tests/OmniSharp.Stdio.Tests/project.json
@@ -1,5 +1,8 @@
 {
   "version": "1.0.0-*",
+  "compilationOptions": {
+    "warningsAsErrors": true
+  },
   "dependencies": {
     "OmniSharp.Stdio": "1.0.0-*",
     "xunit": "2.1.0-beta1-*",

diff --git a/tests/OmniSharp.Tests/BufferManagerFacts.cs b/tests/OmniSharp.Tests/BufferManagerFacts.cs
@@ -1,7 +1,6 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using System.Threading.Tasks;
 using OmniSharp.Models;
 using Xunit;
 
@@ -10,7 +9,7 @@ namespace OmniSharp.Tests
     public class BufferManagerFacts
     {
         [Fact]
-        public async Task UpdateBufferIgnoresVoidRequests()
+        public void UpdateBufferIgnoresVoidRequests()
         {
             var workspace = TestHelpers.CreateSimpleWorkspace("class C {}", "test.cs");
             Assert.Equal(2, workspace.CurrentSolution.Projects.Count());
@@ -29,7 +28,7 @@ public async Task UpdateBufferIgnoresVoidRequests()
         }
 
         [Fact]
-        public async Task UpdateBufferIgnoresFilePathsThatDontMatchAProjectPath()
+        public void UpdateBufferIgnoresFilePathsThatDontMatchAProjectPath()
         {
             var workspace = GetWorkspaceWithProjects();
 
@@ -39,7 +38,7 @@ public async Task UpdateBufferIgnoresFilePathsThatDontMatchAProjectPath()
         }
 
         [Fact]
-        public async Task UpdateBufferFindsProjectBasedOnPath()
+        public void UpdateBufferFindsProjectBasedOnPath()
         {
             var workspace = GetWorkspaceWithProjects();
 
@@ -54,7 +53,7 @@ public async Task UpdateBufferFindsProjectBasedOnPath()
         }
 
         [Fact]
-        public async Task UpdateBufferFindsProjectBasedOnNearestPath()
+        public void UpdateBufferFindsProjectBasedOnNearestPath()
         {
             var workspace = new OmnisharpWorkspace();
 

diff --git a/tests/OmniSharp.Tests/DocumentationConverterFacts.cs b/tests/OmniSharp.Tests/DocumentationConverterFacts.cs
@@ -7,7 +7,7 @@ namespace OmniSharp.Tests
     public class DocumentationConverterFacts
     {
         [Fact]
-        public async Task Converts_xml_documentation_to_plain_text()
+        public void Converts_xml_documentation_to_plain_text()
         {
             var documentation = @"
 <member name=""M:TestNamespace.TestClass.GetZero"">

diff --git a/tests/OmniSharp.Tests/project.json b/tests/OmniSharp.Tests/project.json
@@ -1,5 +1,8 @@
 {
     "version": "1.0.0-*",
+    "compilationOptions": {
+        "warningsAsErrors": true
+    },
     "dependencies": {
         "OmniSharp": "1.0.0-*",
         "xunit": "2.1.0-beta1-*",