fix primitive mapping to a single-prop component

Omegahed · Nov 10, 2016 · 1e67506 · 1e67506
1 parent c62c1c2
commit 1e67506
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/extras/primitives/primitives.js b/src/extras/primitives/primitives.js
@@ -71,7 +71,11 @@ module.exports.registerPrimitive = function registerPrimitive (name, definition)
             mapping = this.mappings[attr.name];
             if (mapping) {
               path = utils.entity.getComponentPropertyPath(mapping);
-              initialComponents[path[0]][path[1]] = attr.value;
+              if (path.constructor === Array) {
+                initialComponents[path[0]][path[1]] = attr.value;
+              } else {
+                initialComponents[path] = attr.value;
+              }
               continue;
             }
 

diff --git a/tests/extras/primitives/primitives.test.js b/tests/extras/primitives/primitives.test.js
@@ -163,4 +163,15 @@ suite('registerPrimitive (using innerHTML)', function () {
       helpers.mixinFactory('foo', {material: 'color: red'}, sceneEl);
     });
   });
+
+  test('handles mapping to a single-property component', function (done) {
+    primitiveFactory({
+      mappings: {
+        viz: 'visible'
+      }
+    }, 'viz="false"', function postCreation (el) {
+      assert.equal(el.getAttribute('visible'), false);
+      done();
+    });
+  });
 });