PAR-2365 - Legal Entities and Trading Names are not displayed for Members uploaded from a CSV File #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bers uploaded from a CSV File Fixes import issues with flysystem php error and updates Drupal view
adam-vessey
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Just noticed this in passing (due to the link to twistor/flysystem-stream-wrapper#27), but this file appears to be empty. I suspect this should have the contents of twistor/flysystem-stream-wrapper#28, diff-/patch-wise?
robwild-affinitydigital
added a commit
that referenced
this pull request
Jul 12, 2024
* PAR-2337 - Updating site Header (#1140) * PAR-2337 - Updating site Header Updates the header to fall inline with the GDS header https://design-system.service.gov.uk/components/header/ - Corrects path in the npm build - Correct composer json to correct alphabetical order - Updates header in par_theme as govuk_theme is out of date - removes redundant scss and css styles (including mobile menu scss as not needed) * PAR-2389 - Password field UI (#1146) Makes the password field follow the pattern from https://design-system.service.gov.uk/components/password-input/ - Updates govuk-frontend to 5.3 - Updates govuk-frontend assets usage - Updates templates to use 5.3 elements * PAR-2450 - Updating page title to use view title (#1147) * PAR-2450 - Updating page title to use view title * PAR-2449 - Adding content for empty table cells (#1148) * PAR-2341 - Adding required field for removing advice reason (#1142) * PAR-2350 - Organisation UI defects (#1143) * PAR-2365 - Legal Entities and Trading Names are not displayed for Members uploaded from a CSV File (#1139) * PAR-2340 - Adding error message to removal of inspection plan * PAR-2365 - Legal Entities and Trading Names are not displayed for Members uploaded from a CSV File Fixes import issues with flysystem php error and updates Drupal view * PAR-2483 - Removing check the ensure trading name has value * PAR-2337 - Fixing UI for header * PAR-2340 - Adding error message to removal of inspection plan (#1141) * PAR2451 - Adding aria-live wrapper to no result and ensuring view uses ajax to maintain focus location (#1151) * PAR-2181 - Adding optional label to form field (#1144) * PAR-2452 - Making view use Ajax for form submission to maintain keyboard focus (#1149) * Fix smoke_test circleCI build * Better fix for circleCI failing job * 2rd attempt at circleCI build * Extending fixes for test_full * PAR-2478 - Updates to email address * Fixing test_full * composer instal on drupal scaffold * Bumping theme version * Adding theme compile into builds * Bumping build * Bumping build * Rebase against master circleCI config * Setting correct db name * Fixing AWS copy to make db available * Bumping build * Adding argument to drop db * Increasing debug for deployment issues * Tweaks to import script * Setting alternate db import path * Fixing syntax * More CircleCI logging * More debugging * Increasing log output * check for db if not copy it * amends to db check * reset to 80.0.40 approach but adding the composer and npm tasks * removing tail limit * Updating composer.lock * removing drop tables as tables do not exist * Bypass db import temporarily * Fixes for 404 and pass strength indicator * Bump theme version * Fixing tabs on profile (stops tab behaviour but preserves UI and removes password strength indicator * Par 2481 (#1157) * Refactored the Advice Page classes. * Refactored the Authority page classes. * Removed an unused library from the Advice Notice Details Page. Refactored the Deviation Request page classes. * Refactored the Enforcement Notice page classes. * Refactored the General Enquiry page classes * Refactored the Cookies page classes. * Refactored the Inspection Feedback page classes. * Refactored the Inspection Plan page classes. * Refactored the Legal Entity page classes. * Refactored the PAR News Letter page classes. * Refactored the Organisation page classes. * Refactored the Page classes in the Other folder. * Refactored the Partnership page classes. * Refactored the page classes in the Shared folder. * Refactored the Transfer Partnership page classes. * Refactored the User Dashboard page classes. * Refactored the User Management page classes. * Updated the method calls to the new refactored code. All tests pass as expected through a full regression test. * Reorganised the variables for ease of reading. * Add the Sign out step to all test features for consistency. * Updated the User profile tests to include the new page tab feature. All tests pass as expected through a full regression. * Added a button click function to hide the Drupal footer bar to allow the Register button to be clicked on the Password page for the Maillog test. * Added a happy tag to all happy path tests. Updated the password field locator to the new ID. Added a comment of another locator type for the Amend legal entities locator. * Trying to restore db import to stage * Stage db deploy revert * Switching to prod seed db * check stage composer version * Removing composer version check and slq drop change * Hard targeting db by name * Resetting to v80 deploy * Breaking down the import task to see for failure * changing db namer * Switching build directories to see if that unpacks it * simplifying paths for db directory * Further printing on directory content * Setting db path to /tmp/workspace/backups and check for file exist * Rolling back to last working version * Changes for db choice * correcting paths * db naming logic correction * locating correct tar file to unpack * altering archive path * checking for correct db * Copy build to remote directory * altering db name * clearing duplicate line * roll out db directories * Clearing redundant steps * Improved the Authority name link click when searching for a partnership. * Moved the Header selection to the base page object class and updated the Registered User header selection step. * Improved the search methods for the User management tests. Updated the Maillog test. All Happy Path tests are passing as expected * PAR-2340 - Disable HTML5 form validation and setting required status correctly * PAR-2485 - Restoring field check * PAR-2360 - Fixing the delete the partnership if the partnership should not be deleted * PAR-2365: Fixing members list upload * Bump theme version to rebuild --------- Co-authored-by: Tom <[email protected]> Co-authored-by: ThommCroft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes import issues with flysystem php error and updates Drupal view
Description
Motivation and Context
https://regulatorydelivery.atlassian.net/browse/PAR-2365
How Has This Been Tested?
Follow steps in the JIRA tasks
Screenshots (if appropriate):
Types of changes
Checklist: