Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go wasi code converge #205

Merged
merged 30 commits into from
Mar 8, 2024
Merged

Go wasi code converge #205

merged 30 commits into from
Mar 8, 2024

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented Mar 5, 2024

Two comments on that:

  • currently there is a little code duplication between jit and arbitrator - in that both need to call wrap! macros for every arbcompress / wasip1 function. There is no logic in that duplication, though.
  • End goal is to have Uptr be a separate type that's still u32 in wasm, but in rust does not have automatic casting casting to/from u32, and have read/write functions only accept that type.

@cla-bot cla-bot bot added the s label Mar 5, 2024
@rachel-bousfield rachel-bousfield changed the base branch from go_wasi_nocopy to stylus March 7, 2024 02:27
@rachel-bousfield rachel-bousfield mentioned this pull request Mar 8, 2024
Copy link
Contributor

@rachel-bousfield rachel-bousfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work :D

@rachel-bousfield rachel-bousfield merged commit 4d47f3c into stylus Mar 8, 2024
8 checks passed
@rachel-bousfield rachel-bousfield deleted the go_wasi_code_reuse branch March 8, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants