Precompile revert test #2655
Draft
Precompile revert test #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Merged
PlasmaPower
reviewed
Sep 10, 2024
| @@ -188,7 +188,7 @@ func TestPrecompilesPerArbosVersion(t *testing.T) { | |||
| log.SetDefault(log.NewLogger(glogger)) | |||
|
|
|||
| expectedNewMethodsPerArbosVersion := map[uint64]int{ | |||
| 0: 89, | |||
| 0: 91, | |||
There was a problem hiding this comment.
We should probably just ignore ArbDebug in this test since it's not on prod chains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test that revert by returning an error is same as revert for failing to parse func output
pulls in: OffchainLabs/nitro-contracts#249
currently marked as draft because I'm not sure we want to merge it (if we add a test that go params size match solidity this test cannot be used)